[NEW] Make channel/group delete call answer to roomName #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reist
force-pushed
the
channel-and-group-delete-by-name
branch
6 times, most recently
from
ae0c03e to
d8a37f3
Compare
graywolf336
approved these changes
May 8, 2017
|
If you do feel like going ahead and adding the |
|
@graywolf336 Alright, I have those changes ready. Should I add them to this request or create a new one? |
reist
force-pushed
the
channel-and-group-delete-by-name
branch
4 times, most recently
from
d5381e0 to
503cfb1
Compare
In .rename, having both name and roomName parameters would be confusing. Also: Sync groups.close error message with channels.close Sync and fix error message in groups.open that was using a parameter that couldn't be there before this patch. Extract the bodyParams/queryParams logic.
reist
force-pushed
the
channel-and-group-delete-by-name
branch
from
503cfb1 to
eab7677
Compare
|
Updated to change all calls except rename and made all the tests pass. Can this get a new review, please? |
rodrigok
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice shortcut, also makes more sense with the returned error (The parameter "roomId" or "roomName" is required).
Would it make sense to update all channel/group calls to accept roomName? The only call that I think really won't play nice with this is rename - with both roomName and name parameters, it'll be confusing.